Skip to content

update jsonptr + json-patch #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2024
Merged

update jsonptr + json-patch #1600

merged 2 commits into from
Oct 11, 2024

Conversation

aviramha
Copy link
Contributor

@aviramha aviramha commented Oct 11, 2024 •
edited
Loading

json-patch has v3 so can update jsonptr.
I also made the requirement less specific, to allow friendlier downstream use (can understand if that's not desired though)
Closes #1563

@aviramha aviramha force-pushed the update_json branch 3 times, most recently from 8768b65 to 98d01ac Compare October 11, 2024 08:19
@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.2%. Comparing base (2280962) to head (04d8ada).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-runtime/src/finalizer.rs 0.0% 6 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #1600   +/-   ##
=====================================
  Coverage   75.2%   75.2%           
=====================================
  Files         82      82           
  Lines       7336    7336           
=====================================
  Hits        5514    5514           
  Misses      1822    1822
Files with missing lines Coverage Δ
kube-core/src/admission.rs 61.2% <ø> (ø)
kube-runtime/src/finalizer.rs 0.0% <0.0%> (ø)

clux
clux approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@clux clux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.
Also, oh, man, they just had breaking change to this api 🙃 (previous from may)

@clux clux added dependencies upgrades to dependencies changelog-change changelog change category for prs labels Oct 11, 2024
@clux clux added this to the 0.97.0 milestone Oct 11, 2024
clux
clux reviewed Oct 11, 2024
View reviewed changes
@aviramha
update jsonptr + json-patch
dcb9174 
Pointer -> PointerBuf

Signed-off-by: Aviram Hassan <aviramyhassan@gmail.com>
@clux clux enabled auto-merge (squash) October 11, 2024 10:27
@clux clux merged commit a6060c4 into kube-rs:main Oct 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
changelog-change changelog change category for prs dependencies upgrades to dependencies
Projects
None yet
Milestone
0.97.0
Development

Successfully merging this pull request may close these issues.

jsonptr / json-patch dependency conflicts
2 participants
@aviramha @clux