Skip to content

Conversation

quantfns
Copy link
Contributor

Came across this message myself because of accidental invalid JSON format and this is also consistent with code comment in fill/silent_filler.go#L22

Came across this message myself because of accidental invalid JSON format and this is also consistent with code comment in fill/silent_filler.go#L22
Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #569 (be3e5d2) into master (9f3b1d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   80.17%   80.17%           
=======================================
  Files          57       57           
  Lines        3848     3848           
=======================================
  Hits         3085     3085           
  Misses        536      536           
  Partials      227      227           

@ktr0731 ktr0731 merged commit f4b08ea into ktr0731:master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants