Skip to content

Use tonistiigi/xx to enable CGO multiplatform builds #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Use tonistiigi/xx to enable CGO multiplatform builds #456

merged 1 commit into from
Apr 10, 2025

Conversation

dereknola
Copy link
Member

Changes

  • Fix releases to properly include CGO build of the binaries
  • Readds riscv64 builds

@dereknola @shanduur
Use xx to enable CGO multiplatform builds
e886e72 
Signed-off-by: Derek Nola <derek.nola@suse.com>
Co-Authored-By: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
@dereknola dereknola requested a review from a team as a code owner April 10, 2025 15:41
VestigeJ
VestigeJ approved these changes Apr 10, 2025
View reviewed changes
Copy link

@VestigeJ VestigeJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢 is @brandond on the hook for install test on RISCV?

@dereknola dereknola merged commit 0e4a6b0 into k3s-io:master Apr 10, 2025
3 checks passed
@dereknola dereknola deleted the use_xx branch April 10, 2025 18:53
@dereknola dereknola mentioned this pull request Apr 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@matttrach matttrach matttrach approved these changes

@VestigeJ VestigeJ VestigeJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dereknola @brandond @matttrach @VestigeJ