Skip to content

Add config file support #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2020
Merged

Add config file support #1899

merged 2 commits into from
Jul 14, 2020

Conversation

erikwilson
Copy link
Contributor

@erikwilson erikwilson commented Jun 13, 2020 •
edited by davidnuzik
Loading

For #1505

@erikwilson erikwilson force-pushed the config-file branch 3 times, most recently from a7ce3b1 to 8e68eab Compare June 18, 2020 23:32
@blaggacao blaggacao mentioned this pull request Jul 7, 2020
Closed
@erikwilson erikwilson force-pushed the config-file branch 3 times, most recently from 033bef8 to 3ebe7a3 Compare July 10, 2020 17:28
@erikwilson erikwilson changed the title WIP - Add config file support Add config file support Jul 13, 2020
@erikwilson erikwilson marked this pull request as ready for review July 13, 2020 17:45
@erikwilson erikwilson requested a review from a team as a code owner July 13, 2020 17:45
brandond
brandond approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandond brandond mentioned this pull request Jul 13, 2020
Closed
briandowns
briandowns approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@briandowns briandowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

galal-hussein
galal-hussein approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@galal-hussein galal-hussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikwilson erikwilson merged commit 66a8c2a into k3s-io:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@galal-hussein galal-hussein galal-hussein approved these changes

@briandowns briandowns briandowns approved these changes

+1 more reviewer

@dweomer dweomer dweomer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erikwilson @brandond @dweomer @galal-hussein @briandowns