Skip to content

[Release-1.33] Emit certs OK event on startup, if no certs need renewal #12760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

[Release-1.33] Emit certs OK event on startup, if no certs need renewal #12760

merged 1 commit into from
Aug 14, 2025
+14 −2

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Aug 14, 2025 •
edited
Loading

Proposed Changes

Backports #12645

Types of Changes

Verification

Testing

Linked Issues

#12646

User-Facing Change

Further Comments

@brandond @dereknola
Emit certs OK event on startup, if no certs need renewal
fc72092 
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@dereknola dereknola marked this pull request as ready for review August 14, 2025 17:24
@dereknola dereknola requested a review from a team as a code owner August 14, 2025 17:24
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.37%. Comparing base (193e241) to head (fc72092).
⚠️ Report is 3 commits behind head on release-1.33.

Files with missing lines Patch % Lines
pkg/certmonitor/certmonitor.go 0.00% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (193e241) and HEAD (fc72092). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (193e241) HEAD (fc72092)
unittests 2 1
e2etests 1 0
Additional details and impacted files 
@@                Coverage Diff                @@
##           release-1.33   #12760       +/-   ##
=================================================
- Coverage         40.09%   20.37%   -19.73%     
=================================================
  Files               185      161       -24     
  Lines             19151    18807      -344     
=================================================
- Hits               7679     3832     -3847     
- Misses            10296    14536     +4240     
+ Partials           1176      439      -737
Flag Coverage Δ
e2etests ?
unittests 20.37% <0.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereknola dereknola merged commit 9357351 into k3s-io:release-1.33 Aug 14, 2025
54 checks passed
@dereknola dereknola mentioned this pull request Aug 15, 2025
Merged
@dereknola dereknola deleted the ok_cert_1.33 branch August 20, 2025 16:17
@cguertin14 cguertin14 mentioned this pull request Aug 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@cwayne18 cwayne18 cwayne18 approved these changes

@vitorsavian vitorsavian vitorsavian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dereknola @brandond @cwayne18 @vitorsavian