Skip to content

Conversation

brandond
Copy link
Member

@brandond brandond commented Aug 12, 2025

Proposed Changes

Follow up to

Ensure that cert checks don't run until after the apiserver is ready to receive events

Types of Changes

enhancement

Verification

Check for event on startup, when all certs are OK.

Testing

Linked Issues

User-Facing Change

Further Comments

Ensure that cert checks don't run until after the apiserver is ready to receive events

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 3d4c2cf)
@brandond brandond requested a review from a team as a code owner August 12, 2025 19:01
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.15%. Comparing base (cdca741) to head (62e03cf).
⚠️ Report is 1 commits behind head on release-1.31.

Files with missing lines Patch % Lines
pkg/certmonitor/certmonitor.go 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cdca741) and HEAD (62e03cf). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cdca741) HEAD (62e03cf)
e2etests 1 0
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.31   #12748       +/-   ##
=================================================
- Coverage         39.65%   20.15%   -19.50%     
=================================================
  Files               186      183        -3     
  Lines             19182    19117       -65     
=================================================
- Hits               7606     3853     -3753     
- Misses            10404    14828     +4424     
+ Partials           1172      436      -736     
Flag Coverage Δ
e2etests ?
unittests 20.15% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brandond brandond merged commit ee389cb into k3s-io:release-1.31 Aug 12, 2025
86 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants