Skip to content

Conversation

brandond
Copy link
Member

@brandond brandond commented Aug 12, 2025

Proposed Changes

Follow up to

Ensure that cert checks don't run until after the apiserver is ready to receive events

Types of Changes

enhancement

Verification

Check for event on startup, when all certs are OK.

Testing

Linked Issues

User-Facing Change

Further Comments

Ensure that cert checks don't run until after the apiserver is ready to receive events

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 3d4c2cf)
@brandond brandond requested a review from a team as a code owner August 12, 2025 19:01
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.20%. Comparing base (a84dc8c) to head (8bd8fd3).
⚠️ Report is 1 commits behind head on release-1.32.

Files with missing lines Patch % Lines
pkg/certmonitor/certmonitor.go 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a84dc8c) and HEAD (8bd8fd3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a84dc8c) HEAD (8bd8fd3)
e2etests 1 0
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.32   #12747       +/-   ##
=================================================
- Coverage         40.10%   20.20%   -19.90%     
=================================================
  Files               185      182        -3     
  Lines             19127    19062       -65     
=================================================
- Hits               7671     3852     -3819     
- Misses            10277    14774     +4497     
+ Partials           1179      436      -743     
Flag Coverage Δ
e2etests ?
unittests 20.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brandond brandond merged commit 2378be8 into k3s-io:release-1.32 Aug 12, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants