Fix cert startup check events #12744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that cert checks don't run until after the apiserver is ready to receive events Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12744 +/- ##
===========================================
- Coverage 40.73% 20.49% -20.25%
===========================================
Files 184 181 -3
Lines 18869 18804 -65
===========================================
- Hits 7687 3854 -3833
- Misses 10005 14514 +4509
+ Partials 1177 436 -741
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgfritch
approved these changes
Aug 12, 2025
manuelbuil
approved these changes
Aug 12, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Follow up to
Ensure that cert checks don't run until after the apiserver is ready to receive events
Types of Changes
enhancement
Verification
Check for event on startup, when all certs are OK.
Testing
Linked Issues
User-Facing Change
Further Comments