Skip to content

[Release-1.33] Add retention flag specific for s3 #12694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

[Release-1.33] Add retention flag specific for s3 #12694

merged 1 commit into from
Aug 5, 2025

Conversation

vitorsavian
Copy link
Member

@vitorsavian vitorsavian commented Aug 1, 2025 •
edited
Loading

@vitorsavian
Add retention flag specific for s3
5e5083d 
* Add retention flag specific for s3
* Add retention for the unit tests:

Signed-off-by: Vitor Savian <vitor.savian@suse.com>
@codecov Codecov
Copy link

codecov bot commented Aug 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.02%. Comparing base (236cbf2) to head (5e5083d).
⚠️ Report is 1 commits behind head on release-1.33.

Files with missing lines Patch % Lines
pkg/etcd/s3/config_secret.go 57.14% 1 Missing and 2 partials ⚠️
pkg/etcd/snapshot.go 0.00% 2 Missing ⚠️
pkg/cli/etcdsnapshot/etcd_snapshot.go 0.00% 1 Missing ⚠️
pkg/cli/server/server.go 0.00% 1 Missing ⚠️
pkg/etcd/s3/s3.go 80.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (236cbf2) and HEAD (5e5083d). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (236cbf2) HEAD (5e5083d)
unittests 6 2
e2etests 1 0
Additional details and impacted files 
@@                Coverage Diff                @@
##           release-1.33   #12694       +/-   ##
=================================================
- Coverage         40.63%   20.02%   -20.61%     
=================================================
  Files               186      183        -3     
  Lines             19305    19246       -59     
=================================================
- Hits               7844     3854     -3990     
- Misses            10264    14956     +4692     
+ Partials           1197      436      -761
Flag Coverage Δ
e2etests ?
unittests 20.02% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vitorsavian vitorsavian marked this pull request as ready for review August 1, 2025 15:20
@vitorsavian vitorsavian requested a review from a team as a code owner August 1, 2025 15:20
@vitorsavian vitorsavian merged commit 88ce8f1 into k3s-io:release-1.33 Aug 5, 2025
87 of 88 checks passed
@cguertin14 cguertin14 mentioned this pull request Aug 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@thomasferrandiz thomasferrandiz thomasferrandiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitorsavian @brandond @thomasferrandiz