Skip to content

Fix completion command in e2e #12693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

Fix completion command in e2e #12693

merged 1 commit into from
Aug 1, 2025

Conversation

brandond
Copy link
Member

@brandond brandond commented Jul 31, 2025 •
edited
Loading

Proposed Changes

Current syntax is incorrect, and while it doesn't break the test it is throwing an error in the logs:

  ==> agent-0: Enabling K3s autocompletion ...
      agent-0: Incorrect Usage: flag provided but not defined: -i
      agent-0: 
      agent-0: NAME:
      agent-0:    k3s completion - Install shell completion script
      agent-0: 
      agent-0: USAGE:
      agent-0:    k3s completion [COMMAND]
      agent-0: 
      agent-0: COMMANDS:
      agent-0:    bash     Bash completion
      agent-0:    zsh      Zsh completion
      agent-0:    help, h  Shows a list of commands or help for one command
      agent-0: 
      agent-0: OPTIONS:
      agent-0:    --help, -h  show help
      agent-0: time="2025-07-31T22:21:55Z" level=fatal msg="Error: flag provided but not defined: -i"
      agent-0: time="2025-07-31T22:21:55Z" level=fatal msg="Error: flag provided but not defined: -i"

Types of Changes

test

Verification

check CI logs

Testing

yes

Linked Issues

n/a

User-Facing Change

Further Comments

@brandond
Fix completion command in e2e
12c5c6e 
Current syntax is incorrect, and while it doesn't break the test it is throwing an error in the logs

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner July 31, 2025 23:36
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.50%. Comparing base (a238f33) to head (12c5c6e).
⚠️ Report is 5 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a238f33) and HEAD (12c5c6e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a238f33) HEAD (12c5c6e)
e2etests 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #12693       +/-   ##
===========================================
- Coverage   40.69%   20.50%   -20.19%     
===========================================
  Files         186      181        -5     
  Lines       19316    18793      -523     
===========================================
- Hits         7861     3854     -4007     
- Misses      10261    14503     +4242     
+ Partials     1194      436      -758
Flag Coverage Δ
e2etests ?
unittests 20.50% <ø> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brandond brandond merged commit be729fc into k3s-io:master Aug 1, 2025
54 checks passed
This was referenced Aug 6, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgfritch mgfritch mgfritch approved these changes

@vitorsavian vitorsavian vitorsavian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandond @mgfritch @vitorsavian