Emit certs OK event on startup, if no certs need renewal #12645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12645 +/- ##
===========================================
- Coverage 40.65% 20.01% -20.65%
===========================================
Files 186 183 -3
Lines 19299 19239 -60
===========================================
- Hits 7846 3850 -3996
- Misses 10257 14955 +4698
+ Partials 1196 434 -762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manuelbuil
approved these changes
Jul 16, 2025
dereknola
approved these changes
Jul 16, 2025
This was referenced Aug 6, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Emit certs OK event on startup, if no certs need renewal
Note that this this event will be emitted once on startup whenever certs are OK, NOT only when certs previously needed renewal as proposed in the linked issue. There are other events that are also emitted by core Kubernetes components every time K3s starts, so this should be fine.
Types of Changes
enhancement
Verification
Check for event on startup, when all certs are OK.
Testing
Linked Issues
User-Facing Change
Further Comments