Update kine and use config defaults helper #12599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12599 +/- ##
===========================================
- Coverage 40.43% 20.01% -20.42%
===========================================
Files 186 183 -3
Lines 19333 19231 -102
===========================================
- Hits 7818 3850 -3968
- Misses 10316 14947 +4631
+ Partials 1199 434 -765
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dereknola
previously approved these changes
Jul 10, 2025
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
|
Looks good to me, great use of DefaultEndpointConfig() for a cleaner setup. Appreciate the kine version bump as well |
vitorsavian
approved these changes
Jul 11, 2025
dereknola
approved these changes
Jul 11, 2025
This was referenced Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update kine and use config defaults helper:
Types of Changes
version bump
Verification
Check version
Testing
Linked Issues
User-Facing Change
Further Comments