Move to more secure trivy workflow based on labels, not comments #12592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Jul 7, 2025
vitorsavian
approved these changes
Jul 7, 2025
|
love this, thank you |
cwayne18
approved these changes
Jul 8, 2025
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 11, 2025
k3s-io#12592) Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 11, 2025
k3s-io#12592) Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 11, 2025
k3s-io#12592) Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Jul 11, 2025
k3s-io#12592) Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Jul 11, 2025
dereknola
added a commit
that referenced
this pull request
Jul 11, 2025
* Move to more secure split trivy workflow based on labels, not comments (#12592) Signed-off-by: Derek Nola <derek.nola@suse.com> * Add basic fuzz test Signed-off-by: Derek Nola <derek.nola@suse.com> * Add retry around common timeout for hardened docker test (#12601) Signed-off-by: Derek Nola <derek.nola@suse.com> * Remove ghcr build cache (#12602) Signed-off-by: Derek Nola <derek.nola@suse.com> * Migrate K3s Release Artifacts to GHA (#12606) Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Jul 11, 2025
* Move to more secure split trivy workflow based on labels, not comments (#12592) Signed-off-by: Derek Nola <derek.nola@suse.com> * Add basic fuzz test Signed-off-by: Derek Nola <derek.nola@suse.com> * Add retry around common timeout for hardened docker test (#12601) Signed-off-by: Derek Nola <derek.nola@suse.com> * Remove ghcr build cache (#12602) Signed-off-by: Derek Nola <derek.nola@suse.com> * Migrate K3s Release Artifacts to GHA (#12606) Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Jul 11, 2025
* Move to more secure split trivy workflow based on labels, not comments (#12592) Signed-off-by: Derek Nola <derek.nola@suse.com> * Add basic fuzz test Signed-off-by: Derek Nola <derek.nola@suse.com> * Add retry around common timeout for hardened docker test (#12601) Signed-off-by: Derek Nola <derek.nola@suse.com> * Remove ghcr build cache (#12602) Signed-off-by: Derek Nola <derek.nola@suse.com> * Migrate K3s Release Artifacts to GHA (#12606) Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Jul 11, 2025
* Move to more secure split trivy workflow based on labels, not comments (#12592) Signed-off-by: Derek Nola <derek.nola@suse.com> * Add basic fuzz test Signed-off-by: Derek Nola <derek.nola@suse.com> * Add retry around common timeout for hardened docker test (#12601) Signed-off-by: Derek Nola <derek.nola@suse.com> * Remove ghcr build cache (#12602) Signed-off-by: Derek Nola <derek.nola@suse.com> * Migrate K3s Release Artifacts to GHA (#12606) Signed-off-by: Derek Nola <derek.nola@suse.com> --------- Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Rework trivy scanning on PR to be more secure:
scan-with-trivyapplied to a PR. This must be done by a k3s-io member with write access. It compiles the k3s image within a unprivilegedpull-requestcontextscan-with-trivylabel. This eliminates the chance of a bad actor usingmakeas a way to inject malicious code inside a privileged context.Types of Changes
CI Change
Verification
See dereknola#31 on my personal fork
Testing
Linked Issues
User-Facing Change
Further Comments