Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 19.96%. Comparing base (e6e3019) to head (05c025b).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e6e3019) and HEAD (05c025b). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (e6e3019)	HEAD (05c025b)
e2etests	1	0

@@             Coverage Diff             @@
##           master   #12590       +/-   ##
===========================================
- Coverage   40.44%   19.96%   -20.48%     
===========================================
  Files         186      184        -2     
  Lines       19071    19254      +183     
===========================================
- Hits         7714     3845     -3869     
- Misses      10170    14975     +4805     
+ Partials     1187      434      -753     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I don't see how this resolved the RKE2 issue, is that expected future work for RKE2?

A much simpler fix would just be len(ARGS) < 1 check, which would solve the k3s completion bash --foo --bar from failing.

I'm not quite clear on what specifically the error this fixes looks like.

I don't see how this resolved the RKE2 issue, is that expected future work for RKE2?

here it's mostly a refac, my plan is to also change the behavior on rke2 to match k3s, but originally the problem was specific to rke2 when the user set the flags after the shell parameter

rke2 completion shell --kubectl --crictl