fix: Remove unused legacy certificates #12541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12541 +/- ##
==========================================
+ Coverage 19.90% 19.92% +0.01%
==========================================
Files 184 184
Lines 19265 19280 +15
==========================================
+ Hits 3835 3841 +6
- Misses 14998 15004 +6
- Partials 432 435 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dereknola
approved these changes
Jun 24, 2025
This was referenced Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The client-kube-proxy.crt and client-k3s-controller.crt certificate files are no longer in use.
This change introduces a
cleanupLegacyCertsfunction that is called during server startup to remove these files from the data directory, preventing clutter and potential confusion.Types of Changes
Bugfix
Linked Issues
#12534
User-Facing Change