Skip to content

Migrate test-mods from Drone to GHA #12137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

Migrate test-mods from Drone to GHA #12137

merged 2 commits into from
Apr 16, 2025

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Apr 15, 2025 •
edited
Loading

Proposed Changes

  • Move the small test-mods pipeline from Drone to GHA, set as a "Unit Test" because it really what it us, we don't need to build K3s, and it just a sanity check that we match correct use the k3s-io fork of k8s dependencies.
  • Don't run amd64 and arm64 Drone pipelines on PR anymore. As you can see from this example run, these pipelines don't run any tests anymore on PR, they just build the binary and exit. Our new CI in GHA covers builds and test on both these platforms.
OLD NEW
image image

Types of Changes

CI

Verification

New CI is green https://github.com/k3s-io/k3s/actions/runs/14475488372/job/40600013584?pr=12137

Testing

It is a test

Linked Issues

#12136

User-Facing Change

Further Comments

@dereknola
Migrate test-mods from Drone to GHA
97da985 
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner April 15, 2025 17:19
@dereknola
Remove Drone amd64 and arm64 pipelines from PRs
954cfc0 
Signed-off-by: Derek Nola <derek.nola@suse.com>

Revert "Remove Drone amd64 and arm64 pipelines from PRs"

This reverts commit 2ec62f1.

x

Signed-off-by: Derek Nola <derek.nola@suse.com>
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.13%. Comparing base (4e8d85a) to head (954cfc0).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #12137      +/-   ##
==========================================
- Coverage   45.17%   45.13%   -0.04%     
==========================================
  Files         189      189              
  Lines       19212    19212              
==========================================
- Hits         8679     8672       -7     
- Misses       9299     9305       +6     
- Partials     1234     1235       +1
Flag Coverage Δ
e2etests 35.60% <ø> (-0.04%) ⬇️
inttests 34.81% <ø> (+<0.01%) ⬆️
unittests 19.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereknola dereknola self-assigned this Apr 16, 2025
matttrach
matttrach approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@matttrach matttrach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skipfiles jobs are defunct now anyways, but maybe we should have something for the GHA that does a similar thing? Have we resolved the problem that updates to docs would run a full integration test?
To be clear, I am asking about future work, this change looks good to me.

@dereknola
Copy link
Member Author

GHA has a build in control for this using the paths-ignore config. See https://github.com/k3s-io/k3s/blob/master/.github/workflows/integration.yaml#L4-L11

I believe we have most stuff covered. You can see on this recent README only PR that no GHA checks ran. #12134

@dereknola dereknola merged commit d824d5d into k3s-io:master Apr 16, 2025
87 of 88 checks passed
This was referenced Apr 16, 2025
Merged
Merged
Merged
Merged
@dereknola dereknola deleted the validate_go_mods branch April 22, 2025 16:53
@dereknola dereknola mentioned this pull request Jul 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@matttrach matttrach matttrach approved these changes

Assignees

@dereknola dereknola

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereknola @brandond @matttrach