fix: resolving inconsistencies in the information structure of list bullets #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Metrics Report
Details | | main (bf73fa0) | #374 (51ed5e9) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 31.7% | 31.7% | +0.0% |
| Files | 26 | 26 | 0 |
| Lines | 3066 | 3060 | -6 |
- | Covered | 972 | 971 | -1 |
- | Code to Test Ratio | 1:0.8 | 1:0.8 | -0.1 |
| Code | 6299 | 6289 | -10 |
- | Test | 5481 | 5464 | -17 |
+ | Test Execution Time | 11s | 9s | -2s |Code coverage of files in pull request scope (38.9% → 39.0%)
Reported by octocov |
Merged
|
ref. #371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML has regular lists (li) and ordered lists (ol), both of which can be expressed in Markdown.
In addition, the notation “a.” and “b.” is not specified in the Markdown specification and is not supported by goldmark. There are no extensions either. Therefore, the processing that parses this as the parsing specification in
package mdis unnecessary, so it has been removed.(By the way, in HTML, you can use the type attribute of ol to display “a.” and “b.”)
In Google Slides, there are two types of bullets: regular and numbered. Alpha is just one way to express numbered bullets.
Therefore, we renamed BulletNumber to BulletNumbered, deleted BulletAlpha, and merged it into BulletNumbered.
This makes it easier to compare the information structure between Markdown and Google Slides.
Originally, BulletAlpha was never used in normal cases, so there are no compatibility changes in behavior.
(In Markdown, there was no such notation as “a.”, and there was no code to handle BulletAlpha when converting from Google Slides to Slide objects.)