chore: enhance and filter error.json #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | main (b9a2be8) | #364 (974148f) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 31.7% | 31.7% | -0.1% |
| Files | 26 | 26 | 0 |
| Lines | 3063 | 3065 | +2 |
| Covered | 972 | 972 | 0 |
- | Code to Test Ratio | 1:0.8 | 1:0.8 | -0.1 |
| Code | 6289 | 6298 | +9 |
| Test | 5476 | 5476 | 0 |
- | Test Execution Time | 9s | 10s | +1s |Code coverage of files in pull request scope (5.8% → 5.2%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in #363 that the contents of the user's content included in the request are included in error.json. This was not very good, so I decided to filter it out of the output. This change to the request output was made in #348.
In addition, to enhance error messages, I embedded the commit hash in the executable file. At the same time, I made the following changes.
deck.version,deck.date, anddeck.commitwere removed from the build configuration as they were not declared in the code.