Skip to content

Conversation

Songmu
Copy link
Collaborator

@Songmu Songmu commented Aug 15, 2025

  • GO111MODULE=on is no longer needed
  • Remove OSNAME, no longer used
  • Remove ghch installation, no longer used
    • BTW, you can use newer gh2changelog instead for similar needs
  • Remove manual release tasks
    • prerelease and release, we've used tagpr GitHub Actions instead
  • Add fulltest and install tasks
  • Update .PHONY

I think you have your own way of doing things, so I would like to hear your opinion. @k1LoW

- GO111MODULE=on is no longer needed
- Remove OSNAME, no longer used
- Remove ghch installation, no longer used
    - BTW, you can use newer gh2changelog instead for similar needs
- Remove manual release tasks
    - prerelease and release, we've used tagpr GitHub Actions instead
- Add `fulltest` and `install` tasks
- Update `.PHONY`
@Songmu Songmu requested a review from k1LoW August 15, 2025 08:02
Copy link
Contributor

Code Metrics Report

main (1a57a6c) #362 (fe1bb02) +/-
Coverage 31.7% 31.7% 0.0%
Code to Test Ratio 1:0.8 1:0.8 0.0
Test Execution Time 12s 9s -3s
Details
  |                     | main (1a57a6c) | #362 (fe1bb02) | +/-  |
  |---------------------|----------------|----------------|------|
  | Coverage            |          31.7% |          31.7% | 0.0% |
  |   Files             |             26 |             26 |    0 |
  |   Lines             |           3063 |           3063 |    0 |
  |   Covered           |            972 |            972 |    0 |
  | Code to Test Ratio  |          1:0.8 |          1:0.8 |  0.0 |
  |   Code              |           6289 |           6289 |    0 |
  |   Test              |           5476 |           5476 |    0 |
+ | Test Execution Time |            12s |             9s |  -3s |

Reported by octocov

Copy link
Owner

@k1LoW k1LoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@Songmu Songmu merged commit 1630fdd into main Aug 15, 2025
1 check passed
@Songmu Songmu deleted the cleanup-makefile branch August 15, 2025 08:15
@github-actions github-actions bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants