Skip to content

Conversation

Songmu
Copy link
Collaborator

@Songmu Songmu commented Aug 15, 2025

  • Service account key
  • Application Default Credentials (ADC)
  • Access token

ADC and access token are used to link with the authentication information output by google-github-actions/auth.

These have been confirmed to work with #355.

This comment has been minimized.

@Songmu Songmu force-pushed the service-account branch 2 times, most recently from 7f9c363 to 61aef69 Compare August 15, 2025 04:26

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Songmu Songmu marked this pull request as ready for review August 15, 2025 05:07
@Songmu Songmu requested a review from k1LoW August 15, 2025 05:08
@Songmu Songmu force-pushed the service-account branch 2 times, most recently from 32cb2b0 to d750625 Compare August 15, 2025 05:16

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Songmu Songmu changed the title feat: Added several authentication methods mainly for service account support feat: support service account with several authentication methods Aug 15, 2025
@Songmu Songmu added minor enhancement New feature or request labels Aug 15, 2025
… support.

- Service account key
- Application Default Credentials (ADC)
- Access token

ADC and access token are used to link with the authentication information output by google-github-actions/auth.
Copy link
Contributor

Code Metrics Report

main (5fe0795) #359 (a1f7fc5) +/-
Coverage 31.9% 31.7% -0.2%
Code to Test Ratio 1:0.8 1:0.8 -0.1
Test Execution Time 11s 11s 0s
Details
  |                     | main (5fe0795) | #359 (a1f7fc5) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          31.9% |          31.7% | -0.2% |
  |   Files             |             26 |             26 |     0 |
  |   Lines             |           3044 |           3063 |   +19 |
  |   Covered           |            972 |            972 |     0 |
- | Code to Test Ratio  |          1:0.8 |          1:0.8 |  -0.1 |
  |   Code              |           6247 |           6289 |   +42 |
  |   Test              |           5476 |           5476 |     0 |
  | Test Execution Time |            11s |            11s |    0s |

Code coverage of files in pull request scope (1.1% → 1.1%)

Files Coverage +/- Status
client.go 0.0% 0.0% modified
deck.go 1.7% +0.0% modified

Reported by octocov

Copy link
Owner

@k1LoW k1LoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Songmu Looks GREAT To Me!!!!! Thank you!!!

const (
// EnvServiceAccountKey - JSON content of a service account key (not a file path).
// Example: DECK_SERVICE_ACCOUNT_KEY='{"type":"service_account","project_id":"..."}'.
EnvServiceAccountKey = "DECK_SERVICE_ACCOUNT_KEY"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DECK_

👍

@Songmu Songmu merged commit 1a57a6c into main Aug 15, 2025
1 check passed
@Songmu Songmu deleted the service-account branch August 15, 2025 07:55
@github-actions github-actions bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants