-
-
Notifications
You must be signed in to change notification settings - Fork 23
feat: support service account with several authentication methods #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+173
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
7f9c363
to
61aef69
Compare
This comment has been minimized.
This comment has been minimized.
61aef69
to
dd16c87
Compare
This comment has been minimized.
This comment has been minimized.
dd16c87
to
1d4d3de
Compare
This comment has been minimized.
This comment has been minimized.
32cb2b0
to
d750625
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d750625
to
5374035
Compare
This comment has been minimized.
This comment has been minimized.
… support. - Service account key - Application Default Credentials (ADC) - Access token ADC and access token are used to link with the authentication information output by google-github-actions/auth.
5374035
to
cbe9ed0
Compare
Code Metrics Report
Details | | main (5fe0795) | #359 (a1f7fc5) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 31.9% | 31.7% | -0.2% |
| Files | 26 | 26 | 0 |
| Lines | 3044 | 3063 | +19 |
| Covered | 972 | 972 | 0 |
- | Code to Test Ratio | 1:0.8 | 1:0.8 | -0.1 |
| Code | 6247 | 6289 | +42 |
| Test | 5476 | 5476 | 0 |
| Test Execution Time | 11s | 11s | 0s | Code coverage of files in pull request scope (1.1% → 1.1%)
Reported by octocov |
k1LoW
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Songmu Looks GREAT To Me!!!!! Thank you!!!
const ( | ||
// EnvServiceAccountKey - JSON content of a service account key (not a file path). | ||
// Example: DECK_SERVICE_ACCOUNT_KEY='{"type":"service_account","project_id":"..."}'. | ||
EnvServiceAccountKey = "DECK_SERVICE_ACCOUNT_KEY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DECK_
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADC and access token are used to link with the authentication information output by google-github-actions/auth.
These have been confirmed to work with #355.