feat: adjust imageReplaceMethod for code blocks #317
Merged
+30
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Metrics Report
Details | | main (ece224a) | #317 (93bbb5e) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 33.3% | 33.3% | +0.0% |
| Files | 23 | 23 | 0 |
| Lines | 2777 | 2783 | +6 |
+ | Covered | 925 | 927 | +2 |
- | Code to Test Ratio | 1:0.9 | 1:0.9 | -0.1 |
| Code | 5603 | 5618 | +15 |
| Test | 5072 | 5072 | 0 |
- | Test Execution Time | 10s | 12s | +2s |Code coverage of files in pull request scope (49.7% → 49.6%)
Reported by octocov |
k1LoW
approved these changes
Jul 27, 2025
Comment on lines
+476
to
+481
| imageReplaceMethod := "CENTER_CROP" | ||
| if info.codeBlock { | ||
| // In the case of code blocks, it is important that the entire image can be seen | ||
| // without being cropped, so switch the replace method. | ||
| imageReplaceMethod = "CENTER_INSIDE" | ||
| } |
There was a problem hiding this comment.
I like the idea of changing the REPLACE METHOD only for the code block.
I think it is a practical solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In code blocks, the aspect ratio and size are undefined, and it is important to display the entire image generated, so I would like to modify the image replacement method.