Skip to content

chore: fix lint warn #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

chore: fix lint warn #487

merged 1 commit into from
Apr 8, 2025

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Apr 8, 2025

SSIA.

@k1LoW k1LoW self-assigned this Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Code Metrics Report

main (c2e8c22) #487 (2cd1aa7) +/-
Coverage 50.7% 50.6% -0.1%
Code to Test Ratio 1:0.5 1:0.5 -0.1
Test Execution Time 30s 30s 0s
Details
  |                     | main (c2e8c22) | #487 (2cd1aa7) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          50.7% |          50.6% | -0.1% |
  |   Files             |             53 |             53 |     0 |
  |   Lines             |           3795 |           3799 |    +4 |
+ |   Covered           |           1925 |           1926 |    +1 |
- | Code to Test Ratio  |          1:0.5 |          1:0.5 |  -0.1 |
  |   Code              |           7442 |           7446 |    +4 |
  |   Test              |           4415 |           4415 |     0 |
  | Test Execution Time |            30s |            30s |    0s |

Code coverage of files in pull request scope (51.3% → 51.1%)

Files Coverage +/-
datastore/mackerel/mackerel.go 0.0% 0.0%
gh/gh.go 16.9% -0.2%
report/custom.go 89.3% 0.0%
report/diff_report.go 62.5% 0.0%
report/report.go 66.4% 0.0%

Benchmark-0 (this is custom metrics test)

main (c2e8c22) #487 (2cd1aa7) +/-
Number of iterations 1000 1000 0
Nanoseconds per iteration 676.5 ns/op 676.5 ns/op 0 ns/op
Metadata
main (c2e8c22) #487 (2cd1aa7)
GOOS darwin darwin
GOARCH amd64 amd64

Benchmark-1 (this is custom metrics test)

main (c2e8c22) #487 (2cd1aa7) +/-
Number of iterations 1500 1500 0
Nanoseconds per iteration 1345 ns/op 1345 ns/op 0 ns/op
Metadata
main (c2e8c22) #487 (2cd1aa7)
GOOS darwin darwin
GOARCH amd64 amd64

Reported by octocov

@k1LoW k1LoW merged commit dc522e0 into main Apr 8, 2025
7 checks passed
@k1LoW k1LoW deleted the fix-lint-warn branch April 8, 2025 15:23
@github-actions github-actions bot mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant