feat: GhA dev publishes #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for publishing development package versions for dev-publish/* branches in both the versioning action and CI workflows.
- Extend
determine-versionaction to detectdev-publish/*branches and generate a-dev-<feature>.<run>suffix - Update
main.ymlto includedev-publishbranches in artifact upload conditions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ci_utils/.github/actions/determine-version/action.yml | Added detection of dev-publish/* branches and custom version formatting |
| .github/workflows/main.yml | Expanded upload conditions to include dev-publish branches |
Comments suppressed due to low confidence (4)
ci_utils/.github/actions/determine-version/action.yml:71
- This
eliffollows a closingfion line 68, causing a syntax error. Merge this condition into the existing if/elif block before thefior move thefiafter all branches.
elif [[ "${{ inputs.github-ref }}" == "refs/heads/dev-publish/"* ]]; then
ci_utils/.github/actions/determine-version/action.yml:72
- [nitpick] Quote variable expansions when parsing with
sedto handle branch names with special characters. For example:
FEATURE_NAME=$(echo "${{ inputs.github-ref }}" | sed -e 's@refs/heads/dev-publish/@@') FEATURE_NAME=$(echo $VERSION | sed -e 's/^dev-publish\///')
.github/workflows/main.yml:187
- Refine the
startsWithpattern to include a trailing slash ('refs/heads/dev-publish/') to avoid matching unintended branch names that share the same prefix.
upload: ${{ github.event_name == 'push' && (startsWith(github.ref, 'refs/heads/release') || startsWith(github.ref, 'refs/heads/hotfix') || startsWith(github.ref, 'refs/heads/dev-publish')) }}
.github/workflows/main.yml:209
- The same upload condition is duplicated in both build jobs. Consider extracting it into a reusable variable, composite action input, or YAML anchor to reduce repetition.
upload: ${{ github.event_name == 'push' && (startsWith(github.ref, 'refs/heads/release') || startsWith(github.ref, 'refs/heads/hotfix') || startsWith(github.ref, 'refs/heads/dev-publish')) }}
fpelliccioni
added a commit
that referenced
this pull request
Jun 26, 2025
fpelliccioni
added a commit
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.