feat: 2025-may post upgrade changes #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements post upgrade changes for the 2025-May release by enabling the bch_galois flag, deprecating the galois_activation_time field, and introducing the cantor_activation_time field. Key changes include:
- Un-commenting the bch_galois field and adjusting related configuration in the header.
- Removing the galois_activation_time configuration and adding a new cantor_activation_time field with a placeholder default.
- Updating the blockchain_helpers and rule_fork headers and adding a new test file (test_2025_issue.cpp) to verify the changes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/kth/capi/config/blockchain_settings.h | Enabled bch_galois; replaced galois_activation_time with cantor_activation_time (placeholder default). |
| include/kth/capi/config/blockchain_helpers.hpp | Mapped bch_galois and added mapping for cantor_activation_time. |
| include/kth/capi/chain/rule_fork.h | Added rule entry for bch_cantor with placeholder activation timestamp. |
| console/test_2025_issue.cpp | New test file introduced to exercise the 2025 post upgrade changes. |
| CMakeLists.txt | Updated test file references to include test_2025_issue.cpp. |
Comments suppressed due to low confidence (3)
include/kth/capi/config/blockchain_settings.h:76
- Consider updating the placeholder 'xxxxxxxxx' with a valid default value or provide clarification on its intended meaning.
// 2027-May hard fork, defaults to xxxxxxxxx: May 15, 2027 12:00:00 UTC protocol upgrade
include/kth/capi/config/blockchain_helpers.hpp:58
- [nitpick] If the 'bch_cantor' flag is intended for future use, please ensure it is mapped consistently or remove the commented-out line to avoid confusion.
// res.bch_cantor = x.bch_cantor;
include/kth/capi/chain/rule_fork.h:68
- Update the placeholder '(xxxxxxxxxxxx)' with the correct hard fork activation timestamp or clarify its purpose in the comment.
kth_rule_fork_bch_cantor = 1U << 24, //2027-May Upgrade - cantor - (xxxxxxxxxxxx)
Comment on lines
+62
to
+69
| // int main(int argc, char* argv[]) { | ||
|
|
||
| // // [2025-05-15 16:36:36.251] [debug] [[blockchain] ] Verify failed [898374] : invalid script | ||
| // // forks : 1082129022 | ||
| // // outpoint : ba77e174d4f966b9286798c4e209a38aac8e56695003c1b863579bd3222a4f92:0 | ||
| // // script : aa204ca6c7c5e1a38241e15beec09220bdb49fdcc3e7c2ae3bf1ea62a1a24e58b7e587 | ||
| // // value : 1000 | ||
| // // inpoint : 44b2125fab5badd600aa29a75c568990fac980bbc53d16e1b7e1cd91942a552c:0 |
There was a problem hiding this comment.
[nitpick] Consider removing or cleaning up large blocks of commented-out code to improve the readability and maintainability of the test file.
Suggested change
| // int main(int argc, char* argv[]) { | |
| // // [2025-05-15 16:36:36.251] [debug] [[blockchain] ] Verify failed [898374] : invalid script | |
| // // forks : 1082129022 | |
| // // outpoint : ba77e174d4f966b9286798c4e209a38aac8e56695003c1b863579bd3222a4f92:0 | |
| // // script : aa204ca6c7c5e1a38241e15beec09220bdb49fdcc3e7c2ae3bf1ea62a1a24e58b7e587 | |
| // // value : 1000 | |
| // // inpoint : 44b2125fab5badd600aa29a75c568990fac980bbc53d16e1b7e1cd91942a552c:0 | |
| // Removed large block of commented-out code for improved readability and maintainability. |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.