feat: VM improvements #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 46 out of 47 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
include/kth/capi/chain/transaction.h:19
- The version parameter has been removed from the kth_chain_transaction_factory_from_data function. Ensure that this change is intentional and that dependent code and documentation are updated accordingly.
kth_transaction_t kth_chain_transaction_factory_from_data(uint8_t* data, kth_size_t n);
3e01a43 to
aaf8112
Compare
There was a problem hiding this comment.
Copilot reviewed 47 out of 48 changed files in this pull request and generated no comments.
Files not reviewed (1)
- CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (3)
include/kth/capi/chain/transaction.h:19
- The version parameter was removed from kth_chain_transaction_factory_from_data; ensure that all callers and documentation are updated to handle this change.
kth_transaction_t kth_chain_transaction_factory_from_data(uint8_t* data, kth_size_t n);
include/kth/capi/chain/script.h:109
- [nitpick] Renaming to kth_chain_script_is_sign_public_key_hash_pattern improves clarity; verify that all references to the previous name have been updated.
kth_bool_t kth_chain_script_is_sign_public_key_hash_pattern(kth_operation_list_t ops);
include/kth/capi/chain/header.h:19
- The version parameter was removed from kth_chain_header_factory_from_data; ensure that upstream callers and documentation reflect this change.
kth_header_t kth_chain_header_factory_from_data(uint8_t* data, kth_size_t n);
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1c52357 to
2dae3b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.