src/chain/output.cpp:101

• [nitpick] Usage of 'create_old' suggests legacy behavior; confirm that this use is intentional and document the expected migration plan if applicable.

auto output = kth::domain::create_old<kth::domain::chain::output>(data_cpp);

src/chain/input.cpp:32

• [nitpick] Usage of 'create_old' with an extra parameter might denote backward compatibility; ensure the rationale is documented for future maintainers.

auto input = kth::domain::create_old<kth::domain::chain::input>(data_cpp, true);

src/chain/header.cpp:16

• [nitpick] Consider documenting why 'create_old' is used here instead of the newer API to avoid confusion for future code updates.

auto header = kth::domain::create_old<kth::domain::chain::header>(data_cpp);

src/chain/block.cpp:29

• [nitpick] Ensure that using 'create_old' for block creation is aligned with the planned refactor strategy and document any differences from the new API.

auto block = kth::domain::create_old<kth::domain::chain::block>(data_cpp);

src/chain/chain_sync.cpp:123

• The witness parameter has been removed in this fetch_block call; verify that the new API behavior remains correct and no required data is omitted.

safe_chain(chain).fetch_block(height, [&](std::error_code const& ec, kth::domain::message::block::const_ptr block, size_t h) {

src/chain/chain_sync.cpp:145

• Removing the witness parameter in the hash-based fetch_block call needs to be double-checked against the updated API design.

safe_chain(chain).fetch_block(hash_cpp, [&](std::error_code const& ec, kth::domain::message::block::const_ptr block, size_t h) {

src/chain/chain_sync.cpp:283

• Ensure that removing the witness parameter in fetch_transaction does not affect transaction validation behavior.

safe_chain(chain).fetch_transaction(hash_cpp, kth::int_to_bool(require_confirmed), [&](std::error_code const& ec, kth::domain::message::transaction::const_ptr transaction, size_t i, size_t h) {

src/chain/chain_sync.cpp:378

• Removing the witness parameter from get_mempool_transactions should be verified to ensure consistency with other API calls and expected mempool behavior.

auto txs = safe_chain(chain).get_mempool_transactions(address_cpp.encoded_cashaddr(false), kth::int_to_bool(use_testnet_rules));

src/chain/chain_sync.cpp:388

• Similarly, check that the removal of the witness parameter in get_mempool_transactions_from_wallets aligns with the updated API definition.

auto txs = safe_chain(chain).get_mempool_transactions_from_wallets(addresses_cpp, kth::int_to_bool(use_testnet_rules));

src/chain/chain_async.cpp:83

• Confirm that the removal of kth::witness from the asynchronous fetch_block call is valid and does not change the intended behavior.

safe_chain(chain).fetch_block(height, [chain, ctx, handler](std::error_code const& ec, kth::domain::message::block::const_ptr block, size_t h) {

src/chain/chain_async.cpp:90

• Make sure the asynchronous block fetch by hash without the witness parameter remains compatible with the underlying API requirements.

safe_chain(chain).fetch_block(hash_cpp, [chain, ctx, handler](std::error_code const& ec, kth::domain::message::block::const_ptr block, size_t h) {

src/chain/chain_async.cpp:143

• Verify that the updated asynchronous fetch_transaction call without the witness parameter still meets the API's data requirements.

safe_chain(chain).fetch_transaction(hash_cpp, kth::int_to_bool(require_confirmed), [chain, ctx, handler](std::error_code const& ec, kth::domain::message::transaction::const_ptr transaction, size_t i, size_t h) {

src/chain/operation.cpp:49

• Deprecating the mutable operation deserialization function is acceptable if all callers have been updated; otherwise, consider a migration strategy.

// kth_bool_t kth_chain_operation_from_data_mutable(kth_operation_t operation, uint8_t const* data, kth_size_t n) {

include/kth/capi/chain/transaction.h:46

• Commenting out the sighash functions indicates deprecation; ensure that downstream consumers are aware of the API change and have migrated accordingly.

// kth_hash_t kth_chain_transaction_hash_sighash_type(kth_transaction_t transaction, uint32_t sighash_type);

include/kth/capi/chain/operation.h:41

• Ensure that the deprecation of the mutable operation function is clearly communicated in the documentation to avoid confusion.

// kth_bool_t kth_chain_operation_from_data_mutable(kth_operation_t operation, uint8_t const* data, kth_size_t n);