-
-
Notifications
You must be signed in to change notification settings - Fork 29
👷 add upstream change detection #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although it would be good to have it open an issue when the hashes change, since it would be hard for someone to notice just by checking when the workflow fails.
SGTM if someone else wants to do the work! 😄 |
I can do it once this is merged. |
const knownWriteHeadHash = '281e0d02084a69893b8c3b8692e3c7c4de2ce22a626217fcf597fa6ddf6955a9' | ||
const knownSetHeaderHash = '2d4f95e92586d28bfd4d3137a8eaacb82b255967d8c26413015c6b56daf0afe7' | ||
const knownAppendHeaderHash = '0deb9f70c3bba63993321cca9281fb4607e2567bed1436b8574c5b86698125a8' | ||
const knownRemoveHeaderHash = '3ad5ccb0a858beb6268f281492bd8d42c9815f5316cc3c4f7f735e142fcd29d9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some automation to update these after a change is looked into? Just to make it easier than copy pasting the new value from the failed build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, should be a straight-forward follow-on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An affront to g*d, but is informational and we can remove it as soon as we are forced to atone
Co-authored-by: Wes Todd <wes@wesleytodd.com>
… run before merging Co-authored-by: Jon Church <me@jonchurch.com>
Bumps [on-headers](https://github.com/jshttp/on-headers) and [compression](https://github.com/expressjs/compression). These dependencies needed to be updated together. Updates `on-headers` from 1.0.2 to 1.1.0 Release notes *Sourced from [on-headers's releases](https://github.com/jshttp/on-headers/releases).* > 1.1.0 > ----- > > Important > --------- > > * Fix [CVE-2025-7339](https://www.cve.org/CVERecord?id=CVE-2025-7339) ([GHSA-76c9-3jph-rj3q](GHSA-76c9-3jph-rj3q)) > > What's Changed > -------------- > > * Migrate CI pipeline to GitHub actions by [`@carpasse`](https://github.com/carpasse) in [jshttp/on-headers#12](https://redirect.github.com/jshttp/on-headers/pull/12) > * fix README.md badges by [`@carpasse`](https://github.com/carpasse) in [jshttp/on-headers#13](https://redirect.github.com/jshttp/on-headers/pull/13) > * add OSSF scorecard action by [`@carpasse`](https://github.com/carpasse) in [jshttp/on-headers#14](https://redirect.github.com/jshttp/on-headers/pull/14) > * fix: use `ubuntu-latest` as ci runner by [`@UlisesGascon`](https://github.com/UlisesGascon) in [jshttp/on-headers#19](https://redirect.github.com/jshttp/on-headers/pull/19) > * ci: apply OSSF Scorecard security best practices by [`@UlisesGascon`](https://github.com/UlisesGascon) in [jshttp/on-headers#20](https://redirect.github.com/jshttp/on-headers/pull/20) > * 👷 add upstream change detection by [`@ctcpip`](https://github.com/ctcpip) in [jshttp/on-headers#31](https://redirect.github.com/jshttp/on-headers/pull/31) > * ✨ add script to update known hashes by [`@ctcpip`](https://github.com/ctcpip) in [jshttp/on-headers#32](https://redirect.github.com/jshttp/on-headers/pull/32) > * 💚 update CI - add newer node versions by [`@ctcpip`](https://github.com/ctcpip) in [jshttp/on-headers#33](https://redirect.github.com/jshttp/on-headers/pull/33) > > New Contributors > ---------------- > > * [`@carpasse`](https://github.com/carpasse) made their first contribution in [jshttp/on-headers#12](https://redirect.github.com/jshttp/on-headers/pull/12) > * [`@UlisesGascon`](https://github.com/UlisesGascon) made their first contribution in [jshttp/on-headers#19](https://redirect.github.com/jshttp/on-headers/pull/19) > * [`@ctcpip`](https://github.com/ctcpip) made their first contribution in [jshttp/on-headers#31](https://redirect.github.com/jshttp/on-headers/pull/31) > > **Full Changelog**: <jshttp/on-headers@v1.0.2...v1.1.0> Changelog *Sourced from [on-headers's changelog](https://github.com/jshttp/on-headers/blob/master/HISTORY.md).* > 1.1.0 / 2025-07-17 > ================== > > * Fix [CVE-2025-7339](https://www.cve.org/CVERecord?id=CVE-2025-7339) ([GHSA-76c9-3jph-rj3q](GHSA-76c9-3jph-rj3q)) Commits * [`4b017af`](jshttp/on-headers@4b017af) 1.1.0 * [`b636f2d`](jshttp/on-headers@b636f2d) ♻️ refactor header array code * [`3e2c2d4`](jshttp/on-headers@3e2c2d4) ✨ ignore falsy header keys, matching node behavior * [`172eb41`](jshttp/on-headers@172eb41) ✨ support duplicate headers * [`c6e3849`](jshttp/on-headers@c6e3849) 🔒️ fix array handling * [`6893518`](jshttp/on-headers@6893518) 💚 update CI - add newer node versions * [`56a345d`](jshttp/on-headers@56a345d) ✨ add script to update known hashes * [`175ab21`](jshttp/on-headers@175ab21) 👷 add upstream change detection ([#31](https://redirect.github.com/jshttp/on-headers/issues/31)) * [`ce0b2c8`](jshttp/on-headers@ce0b2c8) ci: apply OSSF Scorecard security best practices ([#20](https://redirect.github.com/jshttp/on-headers/issues/20)) * [`1a38c54`](jshttp/on-headers@1a38c54) fix: use `ubuntu-latest` as ci runner ([#19](https://redirect.github.com/jshttp/on-headers/issues/19)) * Additional commits viewable in [compare view](jshttp/on-headers@v1.0.2...v1.1.0) Maintainer changes This version was pushed to npm by [ulisesgascon](https://www.npmjs.com/~ulisesgascon), a new releaser for on-headers since your current version. Updates `compression` from 1.8.0 to 1.8.1 Release notes *Sourced from [compression's releases](https://github.com/expressjs/compression/releases).* > v1.8.1 > ------ > > What's Changed > -------------- > > * fix(docs): update multiple links from http to https by [`@Phillip9587`](https://github.com/Phillip9587) in [expressjs/compression#222](https://redirect.github.com/expressjs/compression/pull/222) > * ci: add dependabot for github actions by [`@bjohansebas`](https://github.com/bjohansebas) in [expressjs/compression#207](https://redirect.github.com/expressjs/compression/pull/207) > * build(deps): bump github/codeql-action from 2.23.2 to 3.28.15 by [`@dependabot`](https://github.com/dependabot)[bot] in [expressjs/compression#228](https://redirect.github.com/expressjs/compression/pull/228) > * build(deps): bump ossf/scorecard-action from 2.3.1 to 2.4.1 by [`@dependabot`](https://github.com/dependabot)[bot] in [expressjs/compression#229](https://redirect.github.com/expressjs/compression/pull/229) > * build(deps-dev): bump eslint-plugin-import from 2.26.0 to 2.31.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [expressjs/compression#230](https://redirect.github.com/expressjs/compression/pull/230) > * build(deps-dev): bump supertest from 6.2.3 to 6.3.4 by [`@dependabot`](https://github.com/dependabot)[bot] in [expressjs/compression#231](https://redirect.github.com/expressjs/compression/pull/231) > * [StepSecurity] ci: Harden GitHub Actions by [`@step-security-bot`](https://github.com/step-security-bot) in [expressjs/compression#235](https://redirect.github.com/expressjs/compression/pull/235) > * build(deps): bump github/codeql-action from 3.28.15 to 3.29.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [expressjs/compression#243](https://redirect.github.com/expressjs/compression/pull/243) > * build(deps): bump actions/upload-artifact from 4.3.1 to 4.6.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [expressjs/compression#239](https://redirect.github.com/expressjs/compression/pull/239) > * build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [expressjs/compression#240](https://redirect.github.com/expressjs/compression/pull/240) > * build(deps): bump actions/checkout from 4.1.1 to 4.2.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [expressjs/compression#241](https://redirect.github.com/expressjs/compression/pull/241) > * build(deps-dev): bump eslint-plugin-import from 2.31.0 to 2.32.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [expressjs/compression#244](https://redirect.github.com/expressjs/compression/pull/244) > * deps: on-headers@1.1.0 by [`@UlisesGascon`](https://github.com/UlisesGascon) in [expressjs/compression#246](https://redirect.github.com/expressjs/compression/pull/246) > * Release: 1.8.1 by [`@UlisesGascon`](https://github.com/UlisesGascon) in [expressjs/compression#247](https://redirect.github.com/expressjs/compression/pull/247) > > New Contributors > ---------------- > > * [`@dependabot`](https://github.com/dependabot)[bot] made their first contribution in [expressjs/compression#228](https://redirect.github.com/expressjs/compression/pull/228) > * [`@step-security-bot`](https://github.com/step-security-bot) made their first contribution in [expressjs/compression#235](https://redirect.github.com/expressjs/compression/pull/235) > > **Full Changelog**: <expressjs/compression@1.8.0...v1.8.1> Changelog *Sourced from [compression's changelog](https://github.com/expressjs/compression/blob/master/HISTORY.md).* > 1.8.1 / 2025-07-17 > ================== > > * deps: on-headers@~1.1.0 > + Fix [CVE-2025-7339](https://www.cve.org/CVERecord?id=CVE-2025-7339) ([GHSA-76c9-3jph-rj3q](GHSA-76c9-3jph-rj3q)) Commits * [`83a0c45`](expressjs/compression@83a0c45) 1.8.1 * [`ce62713`](expressjs/compression@ce62713) deps: on-headers@1.1.0 ([#246](https://redirect.github.com/expressjs/compression/issues/246)) * [`f4acb23`](expressjs/compression@f4acb23) build(deps-dev): bump eslint-plugin-import from 2.31.0 to 2.32.0 ([#244](https://redirect.github.com/expressjs/compression/issues/244)) * [`6eaebe6`](expressjs/compression@6eaebe6) build(deps): bump actions/checkout from 4.1.1 to 4.2.2 ([#241](https://redirect.github.com/expressjs/compression/issues/241)) * [`37e0623`](expressjs/compression@37e0623) build(deps): bump ossf/scorecard-action from 2.4.1 to 2.4.2 ([#240](https://redirect.github.com/expressjs/compression/issues/240)) * [`bc436b2`](expressjs/compression@bc436b2) build(deps): bump actions/upload-artifact from 4.3.1 to 4.6.2 ([#239](https://redirect.github.com/expressjs/compression/issues/239)) * [`2f9f572`](expressjs/compression@2f9f572) build(deps): bump github/codeql-action from 3.28.15 to 3.29.2 ([#243](https://redirect.github.com/expressjs/compression/issues/243)) * [`5f13b14`](expressjs/compression@5f13b14) [StepSecurity] ci: Harden GitHub Actions ([#235](https://redirect.github.com/expressjs/compression/issues/235)) * [`76e0945`](expressjs/compression@76e0945) build(deps-dev): bump supertest from 6.2.3 to 6.3.4 ([#231](https://redirect.github.com/expressjs/compression/issues/231)) * [`ae6ee80`](expressjs/compression@ae6ee80) build(deps-dev): bump eslint-plugin-import from 2.26.0 to 2.31.0 ([#230](https://redirect.github.com/expressjs/compression/issues/230)) * Additional commits viewable in [compare view](expressjs/compression@1.8.0...v1.8.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/robfrank/linklift/network/alerts).
we need to know when node makes changes to these methods
open to better ideas though! 😆