Revert back to nwsapi #3667
Merged
Revert back to nwsapi #3667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19e2ff1 to
ae6bd72
Compare
domenic
pushed a commit
that referenced
this pull request
Apr 19, 2025
See: * The previous attempt at #3644. * The performance regression discussion at #3659. * The revert to nwsapi at #3667. The newest version of dom-selector delegates to a fork of nwsapi for some cases to retain higher performance when possible, while using the full power of dom-selector for more complex selectors. The fork is also likely to be less prone to regressions than nwsapi. This fixes many existing selector issues: Fixes #2159. Fixes #3321. Fixes #3370. Fixes #3432. Fixes #3466. Fixes #3469. Fixes #3544. Fixes #3603. Fixes #3610. Fixes #3612. Fixes #3618. Fixes #3620. Fixes #3686. Fixes #3692. Fixes #3750. Fixes #3780. Fixes #3792. Fixes #3802. Fixes #3818.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts (most of) commits c039e52 and 908f27d. Per #3659, the performance of dom-selector is currently too slow.
Closes #3659.