Skip to content

Extend CSS color support with css-color module #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 20, 2024
Merged

Extend CSS color support with css-color module #171

merged 6 commits into from
Dec 20, 2024

Conversation

asamuzaK
Copy link
Contributor

@asamuzaK asamuzaK commented Jan 28, 2024 •
edited
Loading

Currently, support for CSS colors is very limited.
The css-color module covers most of the colors in CSS color module level 4.

NOTE: Colors are converted to specified value, not computed value.

NOTE2: In the test, caching seems to be working.
For this reason, I think the elapsed time displayed in test results are not so reliable.

If I add the same test, elapsed time significantly decreased.

  ✔ should normalize color-mix values (217.8072ms)
  ✔ should normalize color-mix values (2nd attempt) (61.3616ms)
  ✔ should normalize color-mix values (3rd attempt) (0.3769ms)

Fixes #134, fixes #135, fixes #136, fixes #174

@asamuzaK asamuzaK mentioned this pull request Jan 28, 2024
Closed
@themojache themojache mentioned this pull request Apr 13, 2024
Closed
@asamuzaK asamuzaK force-pushed the color branch 3 times, most recently from 5b1ab13 to 20eb33a Compare November 17, 2024 03:20
@asamuzaK asamuzaK marked this pull request as draft November 18, 2024 11:24
@asamuzaK asamuzaK marked this pull request as ready for review December 4, 2024 10:37
@asamuzaK asamuzaK marked this pull request as draft December 14, 2024 00:18
@asamuzaK asamuzaK force-pushed the color branch 2 times, most recently from 4bdf341 to dce39da Compare December 14, 2024 01:46
@asamuzaK asamuzaK marked this pull request as ready for review December 14, 2024 01:52
@asamuzaK
Copy link
Contributor Author

PR ready.
I think we can probably delete lib/named_colors.json as well, but I'm not sure, so I left it as is.

@asamuzaK asamuzaK force-pushed the color branch 2 times, most recently from cd7a423 to 5ed595f Compare December 14, 2024 02:01
domenic
domenic approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@domenic domenic merged commit 8a19acd into jsdom:main Dec 20, 2024
3 checks passed
@asamuzaK asamuzaK deleted the color branch December 20, 2024 05:23
@crutchcorn crutchcorn mentioned this pull request Jan 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@asamuzaK @domenic