Skip to content

wechaty.js.org #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2020
Merged

wechaty.js.org #3723

merged 2 commits into from
Feb 15, 2020

Conversation

huan
Copy link
Contributor

@huan huan commented Feb 13, 2020

MattIPv4
MattIPv4 requested changes Feb 13, 2020
View reviewed changes
@MattIPv4 MattIPv4 changed the title Add wechaty.js.org wechaty.js.org Feb 13, 2020
@MattIPv4
Copy link
Member

In your comment, you are referencing a GitHub Pages site with the requested js.org subdomain as the CNAME file. However, in this PR you are CNAME'ing the subdomain to GitBook. Could you just confirm you are wanting to use GitBook and not the GitHub Pages site?

@huan
Copy link
Contributor Author

huan commented Feb 14, 2020

@MattIPv4 Yes, I confirm that I'm wanting to use GitBook. (the comment is to declare that we own the org on GitHub).

Thank you for double-check that, and appreciate our great service js.org!

@huan @MattIPv4
Update cnames_active.js
0189320 
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
@MattIPv4
Copy link
Member

Hey @huan, do you have a link a preview for the content that will be on the gitbook page?

@MattIPv4 MattIPv4 added awaiting response This PR is waiting for a response from the requester and removed invalid labels Feb 14, 2020
@huan
Copy link
Contributor Author

huan commented Feb 14, 2020

Yes, we have.

The preview link is https://chatie.gitbook.io/wechaty/

We will use this GitBook to server wechaty.js.org.

MattIPv4
MattIPv4 approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit valid, site has content based on https://chatie.gitbook.io/wechaty/

I trust that you've configured GitBook ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed awaiting response This PR is waiting for a response from the requester labels Feb 14, 2020
@indus indus added the 404 The page requested returns a 404 response label Feb 14, 2020
@indus
Copy link
Member

indus commented Feb 14, 2020

I've already added your requested subdomain to JS.ORGs zonefile. But you propably have to configure your host to make use of the custom domain.
I'll merge after we have "contact".

@huan
Copy link
Contributor Author

huan commented Feb 15, 2020 •
edited
Loading

image

@indus Thank you for adding my request.

The GitBook needs us to resolve wechaty.js.org first because it will check the DNS when I configuring it. (see the above screenshot)

@huan
Copy link
Contributor Author

huan commented Feb 15, 2020

@indus The website https://wechaty.js.org can be visiting now, Thank you for the help!

BTW: GitBook still shows me the following the message, however, it does not block the configuration:

The domain is missing a CNAME record pointing to hosting.gitbook.com or the changes haven't propagated yet.

@huan huan mentioned this pull request Feb 15, 2020
Closed
@indus indus removed the 404 The page requested returns a 404 response label Feb 15, 2020
@indus
Copy link
Member

indus commented Feb 15, 2020

Welcome https://wechaty.js.org

@indus indus merged commit db17684 into js-org:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huan @MattIPv4 @indus