Enhance reflective pid-getting for Windows Java 8+ #8310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enebo
approved these changes
Jul 1, 2024
This is a modified version of a patch proposed in jruby#7515 (comment) that uses a third mechanism for getting the PID: the `pid` method added to ProcessImpl in 8 and made public in Process in 9. For JRuby 10, which will target Java 17 or 21, we can just call `pid` directly. Fixes jruby#7515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modified version of a patch proposed in #7515 (comment) that uses a third mechanism for getting the PID: the
pidmethod added to ProcessImpl in 8 and made public in Process in 9.For JRuby 10, which will target Java 17 or 21, we can just call
piddirectly.Fixes #7515