Skip to content

fix(deploy): ignore 401 errors from MavenCentral in waitForStatus() #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix(deploy): ignore 401 errors from MavenCentral in waitForStatus() #1758

merged 1 commit into from
Nov 13, 2024

Conversation

fprochazka
Copy link
Contributor

Fixes #1757

@fprochazka fprochazka requested a review from aalmiray as a code owner November 13, 2024 14:13
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aalmiray
aalmiray requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@aalmiray aalmiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inlined comment

@aalmiray
Copy link
Member

Oh, one more thing, it may be worth to log at trace whenever an unauthorized error is returned as we don't know yet why this happens nor how common this type of events are. The suggested fix will hide them.

Matter of fact, logging in every case seems like the reasonable thing to do IMHO.

@fprochazka fprochazka force-pushed the fp-maven-central-deploy-ignore-401 branch from 4d024c2 to 3363f23 Compare November 13, 2024 15:33
@fprochazka fprochazka force-pushed the fp-maven-central-deploy-ignore-401 branch from 3363f23 to f872590 Compare November 13, 2024 15:42
@fprochazka
Copy link
Contributor Author

Matter of fact, logging in every case seems like the reasonable thing to do IMHO.

I agree, but I'm unsure what's the best practice for this library on how to do that. I've tried something, pls LMK if its passable :)

@aalmiray aalmiray added the bug Something isn't working label Nov 13, 2024
@aalmiray aalmiray added this to the v.1.16.0 milestone Nov 13, 2024
@aalmiray aalmiray merged commit e65cada into jreleaser:main Nov 13, 2024
8 of 9 checks passed
@aalmiray
Copy link
Member

Thank you 😄

@fprochazka fprochazka deleted the fp-maven-central-deploy-ignore-401 branch November 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalmiray aalmiray aalmiray requested changes

Assignees

@fprochazka fprochazka

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.16.0
Development

Successfully merging this pull request may close these issues.

[deploy] Deployment to maven central randomly threw MavenCentralAPIException 401 Unauthorized, which killed the task
3 participants
@fprochazka @CLAassistant @aalmiray