Improve error messages to show problematic position in the filter #3292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the parser and compiler error messages, making it more easier to understand where in the filter the problem is. Like modern compilers, jq will show the line in the filter where the error occurred, will display squiggly line under the invalid token.
ba0089e to
467f441
Compare
180724a to
3c277a7
Compare
3c277a7 to
2f97147
Compare
wader
reviewed
May 17, 2025
| locfile_locate(locations, *loc, "jq: error: %s (Windows cmd shell quoting issues?)", s); | ||
| #else | ||
| locfile_locate(locations, *loc, "jq: error: %s (Unix shell quoting issues?)", s); | ||
| #endif |
There was a problem hiding this comment.
Removed as it might be more confusing than useful to show for all parse errors?
There was a problem hiding this comment.
Yeah, it's less likely an issue of quoting issue in my experience.
wader
approved these changes
May 17, 2025
2f97147 to
cbfb060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the parser and compiler error messages, making
it more easier to understand where in the filter the problem is.
Like modern compilers, jq will show the line in the filter where the
error occurred, will display squiggly line under the invalid token.