Support true color when setting colors from JQ_COLORS #3288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffers for colors were fixed-size and we cannot use longer color definitions like true color, e.g. `JQ_COLORS='38;2;135;200;250'`, or both foreground and background colors, e.g. `JQ_COLORS='38;5;81;48;5;19'`. This commit fixes the implementation to support longer color definitions by allocating the buffers dynamically. This resolves jqlang#2426.
90c174e to
44ab720
Compare
|
Closing in favor of #3282. |
itchyny
added a commit
that referenced
this pull request
May 31, 2025
|
I included the tests in d3cf5ca. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffers for colors were fixed-size and we cannot use longer color
definitions like true color, e.g.
JQ_COLORS='38;2;135;200;250', orboth foreground and background colors, e.g.
JQ_COLORS='38;5;81;48;5;19'.This commit fixes the implementation to support longer color definitions
by allocating the buffers dynamically. This resolves #2426.