Skip to content

Conversation

gromgit
Copy link
Collaborator

@gromgit gromgit commented Nov 3, 2022

The previous attempt (#192) broke the handling of empty files.

Also added tests to catch future regressions.

Fixes #194.

The previous attempt (jpmens#192) broke the handling of empty files.

Also added tests to catch future regressions.

Fixes jpmens#194.
@gromgit gromgit requested a review from jpmens November 3, 2022 15:14
Copy link
Owner

@jpmens jpmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you, Adrian. Running tests now and will then merge.

@jpmens jpmens merged commit 5c01d6e into jpmens:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing an empty file with @ syntax now throws an error on 1.7
2 participants