test pyright ouput lines vs rdjson output #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2ae3e3 to
1293c6b
Compare
1293c6b to
2db9575
Compare
|
Closes #15 |
|
@chadsr Is this one ready to go? If so, could you hit the "Ready for review" button? Thanks! |
|
@jordemort I was hoping to look further for this potential line offset issue, but i'm not sure if I have the time right now. So yeah, let's merge this and any fixes (if needed) can come along later. |
|
@chadsr Upon review it looks like the linters are cranky about a few things; could you take a look at those annotations and appease it, or do you mind if I do it? I really should update the workflow so it does suggestions instead of just check failures. If you click over to the "Files changed" view you can see the things it is complaining about. |
|
@jordemort Shoud be fixed now! |
chadsr
commented
Jan 14, 2022
|
Sorry, dropped off the planet for a bit but I'm back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been seeing some issues with the reviewdog annotation being displayed on the line below where it should be, so I started writing a test suite for the rdjson converter function.
So far the test is passing as expected, so this is a WIP whilst I figure out where the line mismatch might be coming from. (Either way, the script gets a test suite, even if the problem is in reviewdog/pyright itself!)