Execmd: prevent prompting for input #1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@jordansissel |
jordansissel
approved these changes
Nov 14, 2022
|
Looks good. Thank you :) |
This was referenced Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1519 and #1522.
I based my fix off this commit from #1610 that was never merged.
Because Inline::CPP version 0.80 has an interactive Makefile.PL, the bug can be reproduced by running the following command on the main branch (this command will hang):
Part of the issue in #1522 is that @wbraswell could not see the output from cpanminus, however this problem was fixed at some point. I added a test to
util_spec.rbto ensure that the loggerspipemethod is invoked during execution ofsafesystem. I would have liked to sayexpect(logger).to receive(:pipe).with(instance_of(IO) => :info, instance_of(IO) => :info), but rspec does not allow you to use theinstance_ofmatcher on the keys of a hash argument. Due to this limitation I am not able to ensure thatpipeis called with the correct arguments, but this test should still be good enough.