Skip to content

Call ERB.new correctly depending on the RUBY_VERSION #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

Call ERB.new correctly depending on the RUBY_VERSION #1897

merged 1 commit into from
May 2, 2022

Conversation

jordansissel
Copy link
Owner

  • On Ruby 3.0.x and older, call ERB.new(template_code, nil, "-")
  • On Ruby 3.1.0 and newer, call ERB.new(template_code, trim_mode: "-")

Fixes #1894

@jordansissel
Call ERB.new correctly depending on the RUBY_VERSION
2608aec 
* On Ruby 3.0.x and older, call ERB.new(template_code, nil, "-")
* On Ruby 3.1.0 and newer, call ERB.new(template_code, trim_mode: "-")

Fixes #1894
@jordansissel
Copy link
Owner Author

Test results:

% bundle exec rspec spec/fpm/package/rpm_spec.rb spec/fpm/package_spec.rb        
...................................................................................................................................

Finished in 3.64 seconds (files took 0.1879 seconds to load)
131 examples, 0 failures

@jordansissel jordansissel merged commit 7881705 into master May 2, 2022
@jordansissel jordansissel deleted the issue/1894 branch May 2, 2022 05:39
@jordansissel
Copy link
Owner Author

fpm 1.15.0 is released and contains this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby 3.1.0 and above give deprecation warning about ERB.new() usage
1 participant
@jordansissel