Skip to content

fix: Use -q alias when calling fish type command #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2021
Merged

fix: Use -q alias when calling fish type command #29

merged 2 commits into from
Jan 28, 2021

Conversation

SirWrexes
Copy link
Contributor

--quiet is deprecated
See fish-shell/fish-shell@bfb5b28

@joseluisq joseluisq self-assigned this Jan 25, 2021
@joseluisq joseluisq added the enhancement New feature or request label Jan 25, 2021
@joseluisq
Copy link
Owner

Good, but since that --query belongs to Fish v3.2.0 (not released yet) it breaks for example on the latest v3.1.2.
So I will merge this PR as soon as Fish v3.2.0 gets released.

@joseluisq
Copy link
Owner

FYI: The CI passed because it's using master branch, but I will fix that in order to you can see what I refer about.

@SirWrexes
Copy link
Contributor Author

I see.
Maybe then just using -q could be a better way to fix this while staying retro-compatible ?

@joseluisq
Copy link
Owner

joseluisq commented Jan 26, 2021 •
edited
Loading

I see.
Maybe then just using -q could be a better way to fix this while staying retro-compatible ?

Yes, it's better to use the alias -q since it doesn't break on current stable.

So just change it and then I can merge it.

@joseluisq joseluisq changed the title fix: Use --query when calling type fix: Use -q alias when calling fish type command Jan 28, 2021
@joseluisq joseluisq merged commit e3258c5 into joseluisq:master Jan 28, 2021
@joseluisq
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseluisq joseluisq joseluisq approved these changes

Assignees

@joseluisq joseluisq

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SirWrexes @joseluisq