Skip to content

Fix invalid argument error when __gitnow_check_if_branch_exist is used for Fish test checks #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

Fix invalid argument error when __gitnow_check_if_branch_exist is used for Fish test checks #28

merged 1 commit into from
Dec 17, 2020

Conversation

joseluisq
Copy link
Owner

@joseluisq joseluisq commented Dec 17, 2020 •
edited
Loading

This PR fixes an issue when the __gitnow_check_if_branch_exist function is used along with the Fish test on if conditionals. This was occurring because the return type of the function was not consistent.

Here an example of the incoming merge command which uses __gitnow_check_if_branch_exist function.

~> merge --continue
# Invalid argument: 'Provide a valid branch name.'
# ~/.config/fish/conf.d/gitnow.fish (line 282):
#    if test $v_found -eq 0
#       ^
# in function 'merge' with arguments '--continue'
# Already up to date.

@joseluisq joseluisq self-assigned this Dec 17, 2020
@joseluisq
Copy link
Owner Author

FYI: This PR fixes also the issue on the incoming merge command. PR #27.

@joseluisq joseluisq mentioned this pull request Dec 17, 2020
Merged
@joseluisq joseluisq merged commit 708a95a into master Dec 17, 2020
@joseluisq joseluisq deleted the bugfix/Invalid_argument_error_for_gitnow_check_if_branch_exist branch December 17, 2020 10:00
@joseluisq joseluisq restored the bugfix/Invalid_argument_error_for_gitnow_check_if_branch_exist branch December 17, 2020 10:00
@joseluisq joseluisq deleted the bugfix/Invalid_argument_error_for_gitnow_check_if_branch_exist branch December 17, 2020 10:17
@joseluisq joseluisq added this to the 2.6.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joseluisq joseluisq

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@joseluisq