Skip to content

Speed up .gitnow config file processing #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2020
Merged

Speed up .gitnow config file processing #24

merged 2 commits into from
Oct 6, 2020

Conversation

joseluisq
Copy link
Owner

This PR speeds up processing of the .gitnow config file which also speeds up Fish sessions startup.
Resolves #23

Specs:

  • ArchLinux x86_64 / Intel Core i7 2.5GHz / 8GB RAM
  • Fish v3.1.2
  • Fisher v3.2.11
  • Gitnow v2.5.0

Before:

~> time fish -c ''
________________________________________________________
Executed in  441,87 millis    fish           external 
   usr time  376,85 millis    0,00 micros  376,85 millis 
   sys time   83,83 millis  1001,00 micros   82,82 millis

After:

~> time fish -c ''
________________________________________________________
Executed in  232,03 millis    fish           external 
   usr time  187,56 millis  709,00 micros  186,85 millis 
   sys time   62,72 millis  163,00 micros   62,55 millis

@joseluisq joseluisq added the enhancement New feature or request label Oct 5, 2020
@joseluisq joseluisq self-assigned this Oct 5, 2020
@joseluisq joseluisq merged commit 61edbe0 into master Oct 6, 2020
@joseluisq joseluisq added this to the 2.5.1 milestone Oct 6, 2020
@joseluisq joseluisq deleted the optimizations branch October 6, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joseluisq joseluisq

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

Fish startup time increases significantly with this plugin
1 participant
@joseluisq