Skip to content

Add annotated tags support for tag command #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 11, 2021
Merged

Add annotated tags support for tag command #42

merged 9 commits into from
Aug 11, 2021

Conversation

lukasgierth
Copy link
Contributor

@lukasgierth lukasgierth commented Aug 6, 2021 •
edited by joseluisq
Loading

Adds the --annotate option to create a tag as an annotated one.

Resolves #41

@joseluisq joseluisq changed the title --annotate in tags Add annotated tags support for tag command Aug 6, 2021
@joseluisq joseluisq self-assigned this Aug 6, 2021
@joseluisq joseluisq added the enhancement New feature or request label Aug 6, 2021
joseluisq
joseluisq reviewed Aug 10, 2021
View reviewed changes
Copy link
Owner

@joseluisq joseluisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor question to clarify then it should be ready to merge.

@joseluisq
Copy link
Owner

What I have realized is that custom tags creation like tag whatever or tag -a whatever is not working.
Would you like to make that happen?

@lukasgierth
Copy link
Contributor Author

What I have realized is that custom tags creation like tag whatever or tag -a whatever is not working.
Would you like to make that happen?

I also noticed while testing for this pull request. I will look at it but not in this pull request i think.

@joseluisq
Copy link
Owner

I also noticed while testing for this pull request. I will look at it but not in this pull request i think.

Yeah, Maybe another PR for it.

@joseluisq joseluisq merged commit a2e5259 into joseluisq:master Aug 11, 2021
@joseluisq
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseluisq joseluisq joseluisq approved these changes

Assignees

@joseluisq joseluisq

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend tag command for annotated Tags
2 participants
@lukasgierth @joseluisq