Add non-confirmation-bias mode #465
Conversation
There was a problem hiding this comment.
Thanks for this! I've added a few comments to address before I can merge it in. There's also a new conflict, as I've pushed since the last commit (sorry).
P.S. for future PRs, it's helpful to exclude formatting changes that are unrelated to the change that the PR targets - it makes it a lot easier to review. git add -p is helpful here 🙂
lib/generated/intl/messages_en.dart
Outdated
| @@ -74,6 +74,12 @@ class MessageLookup extends MessageLookupByLibrary { | |||
| "about": MessageLookupByLibrary.simpleMessage("About"), | |||
| "account_suspended": | |||
| MessageLookupByLibrary.simpleMessage("Account suspended"), | |||
| "activate_non_confirmation_bias_mode_description": | |||
| MessageLookupByLibrary.simpleMessage( | |||
| "Don\'t show the author of the tweet on a post. Avoid confirmation bias based on authoritative arguments."), | |||
There was a problem hiding this comment.
I think this description is a bit long, and probably won't fit on one line on most devices. Maybe truncate it to Don't show tweet authors, as the title declares it as "non-confirmation bias mode" already
There was a problem hiding this comment.
This one's still outstanding, I think
There was a problem hiding this comment.
Take a look at the intl_en.arb file, the messages_en.dart is generated based on it.
lib/generated/intl/messages_en.dart
Outdated
| "Don\'t show the author of the tweet on a post. Avoid confirmation bias based on authoritative arguments."), | ||
| "activate_non_confirmation_bias_mode_label": | ||
| MessageLookupByLibrary.simpleMessage( | ||
| "Activate non-confirmation-bias-mode"), |
There was a problem hiding this comment.
I think this should just be Activate non-confirmation bias mode, as this is an open compound
lib/main.dart
Outdated
| @@ -180,6 +177,7 @@ Future<void> main() async { | |||
| optionThemeTrueBlack: false, | |||
| optionThemeColorScheme: 'aquaBlue', | |||
| optionTrendsLocation: jsonEncode({'name': 'Worldwide', 'woeid': 1}), | |||
| optionImproveNonConfirmationBias: false, | |||
There was a problem hiding this comment.
optionNonConfirmationBiasMode fits better, as it's more 1:1 with the name of the preference.
# Conflicts: # lib/settings/_general.dart
|
@jonjomckay Should be fixed. Before merging you may look if you like this design change, I think we should add a button like "Go to author" or "Show author" so that people know this area is clickable. |
|
btw, shouldn't |
Probably yeah. I'll look into it! |
|
While testing out the beta version, I realized that the current implementation feels a bit off. It surely does because you are used to see an user icon and a name - I thought about how we add a generic user profile and the name "user", so it doesn't feel that off. What do you think @jonjomckay? I can create a PR if you'd like |
|
@Myzel394 that sounds good to me! It does feel a little strange seeing a black box there 😅 |
People believe some people more than others. We believe for example that Albert Einstein knows more about physics more than our grandmother, just because it's Albert Einstein. Only a few people would actually check his work and see if he was right or not.
To avoid this confirmation bias based on authority, you should have an option to hide the authors, so that you don't know who made a tweet.
This is what this PR accomplishes.
Please let me know how you like it and whether we need to add something more to add / change something.
Btw, @jonjomckay that's a very clean codebase! It was very easy to create this PR, thanks for your awesome work! ❤️ :)