Skip to content

Refactor New Relic usage #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2017
Merged

Refactor New Relic usage #324

merged 1 commit into from
Nov 2, 2017

Conversation

adamors
Copy link
Contributor

@adamors adamors commented Oct 30, 2017

Metrics were recorded through a deprecated API, added support for the newer one.

As you can see here, the get_stats method was deprecated and the suggested change is

If you had chained get_stats with record_data_point, use:
NewRelic::Agent.record_metric

https://docs.newrelic.com/docs/agents/ruby-agent/installation/upgrade-ruby-agent-versions

@adamors
Refactor newrelic metrics
8d1bab1 
Metrics were recorded through a deprecated API, added support for the
newer one.
@michaelklishin
Copy link
Collaborator

Thank you.

@michaelklishin michaelklishin merged commit 5043c16 into jondot:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamors @michaelklishin