Skip to content

Update to Typescript definitions. #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2024
Merged

Update to Typescript definitions. #721

merged 2 commits into from
Mar 19, 2024

Conversation

kevin-nano
Copy link
Contributor

I'm using Typescript with the library and having some typing issues with the library.

  • Matrix#multiply has some typing issues when trying to multiply a Vector. This patch fixes the overloads of the function.
  • Added Two.BoundingBox to be able to use the returned object of getBoundingClientRect functions more easily.

@jonobr1
Copy link
Owner

jonobr1 commented Mar 19, 2024

Awesome, thank you!

@jonobr1 jonobr1 merged commit eb50447 into jonobr1:dev Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin-nano @jonobr1