Skip to content

Conversation

crgk
Copy link
Contributor

@crgk crgk commented Dec 22, 2022

I spotted some minor errors/typos in the docs for makeLinearGradient and makeRadialGradient. Here's a quick patch to fix.

Thanks for the project! I've really enjoyed using it.

@crgk
Copy link
Contributor Author

crgk commented Dec 22, 2022

Hmm, I'm surprised by how big the types.d.ts diff is. Maybe I shouldn't have regenerated that?

@jonobr1
Copy link
Owner

jonobr1 commented Dec 22, 2022

Yeah, sorry about that. The generation script for Types is out of sync with the types.d.ts file. If you don't mind rolling that back. I'd be happy to add your PR.

@crgk
Copy link
Contributor Author

crgk commented Dec 23, 2022

All set! Thanks for having a look.

@jonobr1 jonobr1 merged commit 96220a0 into jonobr1:dev Dec 23, 2022
@jonobr1
Copy link
Owner

jonobr1 commented Dec 23, 2022

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants