fix: correctly handle for-sure tag and delete logic if disk usage was… #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of the JellysweepDeleteForSureTag and improves disk usage tag logic when disk usage monitoring is disabled. The change simplifies the deletion logic by removing complex special-case handling for the for-sure tag.
- Removes complex special logic for JellysweepDeleteForSureTag that was calculating adjusted deletion dates
- Adds explicit filtering to skip disk usage tags in the ShouldTriggerDeletion function
- Simplifies the ShouldTriggerDeletionBasedOnDiskUsage function by removing for-sure tag special handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… disabled
closes #45