Vendor cloudpickle 3.0.0 and drop support for Python 3.7. #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
- Coverage 95.10% 95.03% -0.07%
==========================================
Files 45 45
Lines 7553 7553
==========================================
- Hits 7183 7178 -5
- Misses 370 375 +5 ☔ View full report in Codecov by Sentry. |
ogrisel
commented
Oct 17, 2023
|
@tomMoral BTW we could probably simplify the loky code base quite significantly by dropping backward compat for Python 3.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudpickle does no longer support Python 3.7 (released more than 5 years ago and no longer supported by the CPython team) so we could bump up the dependency.
Note we should bump up the other Python deps on the CI to also test with recent versions of Python 3.12, numpy, dask and such but we should probably do that in a dedicated PR.