Simplified generator unordered #1500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor_unordered advantages
…aways with reasonably fast tasks
… latest completion)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1500 +/- ##
==========================================
- Coverage 94.96% 94.89% -0.08%
==========================================
Files 45 45
Lines 7474 7521 +47
==========================================
+ Hits 7098 7137 +39
- Misses 376 384 +8
☔ View full report in Codecov by Sentry. |
|
The failure observed for EDIT: I clicked "re-run" and now this test pass on the windows CI so it's an heisen failure unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the same content as #1463 + a simplification.
I created a new PR to make it possible to run the full CI on the last commit. If it works, it can be cherry-picked into #1463 instead of merging this.