-
Notifications
You must be signed in to change notification settings - Fork 434
borda/pyproject PR but with flake8 revert #1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1460 +/- ##
==========================================
- Coverage 94.77% 94.71% -0.06%
==========================================
Files 44 44
Lines 7306 7439 +133
==========================================
+ Hits 6924 7046 +122
- Misses 382 393 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to say when someone takes my work/PR and creates it as his contribution/PR 😕 |
@Borda I forked it to add a commit to revert the flake8 part but your original commits were not removed. You will still appear as the contributor of the commit. |
@fcharras any reason why you could not append your commit to the original PR? Moreover, you could just ask me to do this change as you see was patient and responding fast |
We are in the process of releasing, we were in a hurry so we decided to finish the PR and to try to merge this quickly (we had a permission issue to push on yours). We kept all your commit so you would have been credited anyway but if you mind this, we will merge the original pr. (We found out how to bypass the permission issue). |
Add a commit to #1433 to keep the changes except the flake8 part.